From commits-return-1653-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Tue May 28 14:27:23 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6641B18060F for ; Tue, 28 May 2019 16:27:23 +0200 (CEST) Received: (qmail 4092 invoked by uid 500); 28 May 2019 14:27:22 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 4083 invoked by uid 99); 28 May 2019 14:27:22 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 May 2019 14:27:22 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] adriancole commented on issue #2616: Not all client to client relations taken into account in 'Dependencies' tree Message-ID: <155905364271.1421.6474617830374806425.gitbox@gitbox.apache.org> Date: Tue, 28 May 2019 14:27:22 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on issue #2616: Not all client to client relations taken into account in 'Dependencies' tree URL: https://github.com/apache/incubator-zipkin/issues/2616#issuecomment-496540456 ps looking at your data span 076fecc8a861e28e, I think localEndpoint.serviceName ="auth" should have been remoteEndpoint.serviceName= "auth" if in the same process. you could make the case that a child span of a client that is an incidental request could make another link to an uninstrumented service.. just it would need to be a link to the service identified as remoteEndpoint.serviceName. localEndpoint.serviceName should be constant for the local call tree starting with the inbound server request. IOTW I think there is a little bit of things in the wrong spot. Does that make sense? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services