From commits-return-1650-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Tue May 28 13:32:25 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9A1FB18060F for ; Tue, 28 May 2019 15:32:25 +0200 (CEST) Received: (qmail 78415 invoked by uid 500); 28 May 2019 13:32:25 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 78406 invoked by uid 99); 28 May 2019 13:32:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 May 2019 13:32:25 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] tmichnik1981 commented on issue #2616: Not all client to client relations taken into account in 'Dependencies' tree Message-ID: <155905034115.1948.10443192119059898989.gitbox@gitbox.apache.org> Date: Tue, 28 May 2019 13:32:21 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit tmichnik1981 commented on issue #2616: Not all client to client relations taken into account in 'Dependencies' tree URL: https://github.com/apache/incubator-zipkin/issues/2616#issuecomment-496517846 Hi @adriancole , Don't you think it is worth to present on the dependency graph all the requests even within the same runtime? I believe it is quite normal that developers may want to generate spans to measure/visualize requests/responses between different components of the same application. For example someone might generate spans to profile/measure the code flow connecting to some database. It would be pretty valuable to see what happened on the dependency graph. Assuming that, the dependency graph must be limited only to RPC CLIENT --> SERVER calls, there is still something wrong. The condition which I mentioned above: ``` if (Kind.CLIENT.equals(kind) && !current.children().isEmpty()) { continue; } ``` omits relations between server and client as client component has some descendants. component A ( SERVER) --> component B (CLIENT) --> SOME_OTHER_SPANS ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services