From commits-return-1637-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Mon May 27 12:18:47 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3A8D3180638 for ; Mon, 27 May 2019 14:18:47 +0200 (CEST) Received: (qmail 48690 invoked by uid 500); 27 May 2019 12:18:46 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 48681 invoked by uid 99); 27 May 2019 12:18:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 May 2019 12:18:46 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] shakuzen commented on a change in pull request #2611: Handle exceptions without message. Message-ID: <155895952120.26260.11898465571006796185.gitbox@gitbox.apache.org> Date: Mon, 27 May 2019 12:18:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit shakuzen commented on a change in pull request #2611: Handle exceptions without message. URL: https://github.com/apache/incubator-zipkin/pull/2611#discussion_r287767892 ########## File path: zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java ########## @@ -235,13 +235,19 @@ static HttpData convertRequest(ServiceRequestContext ctx, AggregatedHttpMessage final class BodyIsExceptionMessage implements ExceptionHandlerFunction { + static final Logger LOGGER = LogManager.getLogger(); + @Override public HttpResponse handleException(RequestContext ctx, HttpRequest req, Throwable cause) { ZipkinHttpCollector.metrics.incrementMessagesDropped(); + + LOGGER.warn("Unexpected error handling request.", cause); Review comment: I'm not sure we want to add this logging in all cases. It seems too verbose to me for bad requests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services