From commits-return-1502-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Sat May 18 07:38:22 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 40CA318064C for ; Sat, 18 May 2019 09:38:22 +0200 (CEST) Received: (qmail 1317 invoked by uid 500); 18 May 2019 07:38:21 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 1308 invoked by uid 99); 18 May 2019 07:38:21 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 18 May 2019 07:38:21 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] trustin commented on a change in pull request #2604: Moves to Armeria 0.86 Message-ID: <155816509798.9280.181938735968636186.gitbox@gitbox.apache.org> Date: Sat, 18 May 2019 07:38:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit trustin commented on a change in pull request #2604: Moves to Armeria 0.86 URL: https://github.com/apache/incubator-zipkin/pull/2604#discussion_r285332803 ########## File path: zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java ########## @@ -213,7 +214,7 @@ static HttpData convertRequest(ServiceRequestContext ctx, AggregatedHttpMessage String encoding = request.headers().get(HttpHeaderNames.CONTENT_ENCODING); HttpData content = request.content(); if (!content.isEmpty() && encoding != null && encoding.contains("gzip")) { - content = GZIP_DECODER_FACTORY.newDecoder().decode(content); + content = GZIP_DECODER_FACTORY.newDecoder(ByteBufAllocator.DEFAULT).decode(content); Review comment: You can use ctx.alloc() 😄 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services