From commits-return-1393-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Wed May 15 14:10:48 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id DE2B3180621 for ; Wed, 15 May 2019 16:10:47 +0200 (CEST) Received: (qmail 61403 invoked by uid 500); 15 May 2019 14:10:47 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 61388 invoked by uid 99); 15 May 2019 14:10:47 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 May 2019 14:10:47 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] adriancole commented on issue #2596: Try to downsize a little Message-ID: <155792944217.1527.12717993658422597542.gitbox@gitbox.apache.org> Date: Wed, 15 May 2019 14:10:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on issue #2596: Try to downsize a little URL: https://github.com/apache/incubator-zipkin/issues/2596#issuecomment-492671284 I looked at some suspicious once.. jsoup is 400K and deals with something that seems normal string replacement should work out. Basically, we should be able to control our index.html generation in lens and ui to always emit the base tag, eliminating this logic: https://github.com/apache/incubator-zipkin/blob/master/zipkin-server/src/main/java/zipkin2/server/internal/ui/ZipkinUiConfiguration.java#L116-L120 then, the replacement here should be normal string replacement. Note: I just checked and here is the base tag in our two UIs zipkin-ui: `` zipkin-lens: `` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services