From commits-return-1221-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Sat May 11 09:18:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AEB15180651 for ; Sat, 11 May 2019 11:18:07 +0200 (CEST) Received: (qmail 98026 invoked by uid 500); 11 May 2019 09:18:07 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 98015 invoked by uid 99); 11 May 2019 09:18:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 May 2019 09:18:07 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] adriancole commented on issue #2584: Adds cheap string encoding for IpV4 path used in protobuf Message-ID: <155756628650.21916.6906530636610486271.gitbox@gitbox.apache.org> Date: Sat, 11 May 2019 09:18:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on issue #2584: Adds cheap string encoding for IpV4 path used in protobuf URL: https://github.com/apache/incubator-zipkin/pull/2584#issuecomment-491494718 note: this puts us within "spitting distance" of grpc's proto library, yet with no external dependencies ``` ProtoCodecBenchmarks.bytes_protobufDecoder:bytes_protobufDecoder·p0.99 sample 1974.108 us/op ProtoCodecBenchmarks.bytes_protobufDecoder:·gc.alloc.rate.norm sample 15 2023204.399 ± 33.559 B/op ProtoCodecBenchmarks.bytes_wireDecoder:bytes_wireDecoder·p0.99 sample 2368.840 us/op ProtoCodecBenchmarks.bytes_wireDecoder:·gc.alloc.rate.norm sample 15 2435408.756 ± 54.127 B/op ProtoCodecBenchmarks.bytes_zipkinDecoder:bytes_zipkinDecoder·p0.99 sample 2162.688 us/op ProtoCodecBenchmarks.bytes_zipkinDecoder:·gc.alloc.rate.norm sample 15 2095172.026 ± 45.379 B/op ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services