From commits-return-1218-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Sat May 11 09:14:18 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 63A6A180651 for ; Sat, 11 May 2019 11:14:18 +0200 (CEST) Received: (qmail 94758 invoked by uid 500); 11 May 2019 09:14:17 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 94749 invoked by uid 99); 11 May 2019 09:14:17 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 May 2019 09:14:17 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] adriancole opened a new pull request #2584: Adds cheap string encoding for IpV4 path used in protobuf Message-ID: <155756605759.18418.2389403393254563852.gitbox@gitbox.apache.org> Date: Sat, 11 May 2019 09:14:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole opened a new pull request #2584: Adds cheap string encoding for IpV4 path used in protobuf URL: https://github.com/apache/incubator-zipkin/pull/2584 Commonly, we parse protobuf, but write json. This implies reading bytes and encoding IP literals. This improves performance of IpV4 address encoding and tries to pay for the extra bytecode by removing some. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services