From commits-return-1205-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Sat May 11 07:33:39 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id F26DC180651 for ; Sat, 11 May 2019 09:33:38 +0200 (CEST) Received: (qmail 24063 invoked by uid 500); 11 May 2019 07:33:38 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 24050 invoked by uid 99); 11 May 2019 07:33:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 May 2019 07:33:38 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] anuraaga commented on issue #2582: Reuse char[] buffer when decoding hex fields. Message-ID: <155756001311.22225.6040759326720379563.gitbox@gitbox.apache.org> Date: Sat, 11 May 2019 07:33:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anuraaga commented on issue #2582: Reuse char[] buffer when decoding hex fields. URL: https://github.com/apache/incubator-zipkin/pull/2582#issuecomment-491488147 Hmm - in that case does it make sense for me to add `zipkin2.internal.HexConversionBuffer` which can be used by brave too? No point to have multiple threadlocals all over. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services