From commits-return-1202-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Sat May 11 07:26:40 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 076B9180651 for ; Sat, 11 May 2019 09:26:39 +0200 (CEST) Received: (qmail 18142 invoked by uid 500); 11 May 2019 07:26:39 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 18133 invoked by uid 99); 11 May 2019 07:26:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 May 2019 07:26:39 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] adriancole commented on issue #2582: Reuse char[] buffer when decoding hex fields. Message-ID: <155755959868.18101.8258378764438964923.gitbox@gitbox.apache.org> Date: Sat, 11 May 2019 07:26:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on issue #2582: Reuse char[] buffer when decoding hex fields. URL: https://github.com/apache/incubator-zipkin/pull/2582#issuecomment-491487605 this is the change that added tests in brave to ensure our code is unloadable.. I changed the threadlocal in b3 single to anonymous just to make sure and it failed the test https://github.com/apache/incubator-zipkin-brave/pull/787 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services