From commits-return-1144-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Fri May 10 14:09:05 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8288F18061A for ; Fri, 10 May 2019 16:09:05 +0200 (CEST) Received: (qmail 60653 invoked by uid 500); 10 May 2019 14:09:04 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 60644 invoked by uid 99); 10 May 2019 14:09:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 May 2019 14:09:04 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] adriancole commented on issue #2579: Benchmark bytes / bytebuffer, protobuf vs zipkin vs wire. Message-ID: <155749733967.26896.16065433256069915809.gitbox@gitbox.apache.org> Date: Fri, 10 May 2019 14:08:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on issue #2579: Benchmark bytes / bytebuffer, protobuf vs zipkin vs wire. URL: https://github.com/apache/incubator-zipkin/pull/2579#issuecomment-491302237 @anuraaga leaning towards not changing anything I guess you mean changing the parsing approach? If so, I would say even if we wanted to, it can wait. we are allocating more per request in parsing than necessary, but it is hard to tell the impact without looking at the total stuff allocated along the way. Regardless, I think we should merge your benchmarks so it can be picked up later. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services