From commits-return-1053-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Fri May 10 04:18:51 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 59207180649 for ; Fri, 10 May 2019 06:18:51 +0200 (CEST) Received: (qmail 18176 invoked by uid 500); 10 May 2019 04:18:50 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 18167 invoked by uid 99); 10 May 2019 04:18:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 May 2019 04:18:50 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] adriancole commented on issue #2573: Implements deduplication in Elasticsearch Message-ID: <155746193062.13199.13474293475876946429.gitbox@gitbox.apache.org> Date: Fri, 10 May 2019 04:18:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on issue #2573: Implements deduplication in Elasticsearch URL: https://github.com/apache/incubator-zipkin/pull/2573#issuecomment-491149875 OK I'm personally happy with this. the line corresponding to GC time (100ms) and heap used (<100MiB) is stable throughout the load (8.5Kspans/second indexing into ES in my laptop) ![Screen Shot 2019-05-10 at 12 16 44 PM](https://user-images.githubusercontent.com/64215/57502274-93a7bc00-731d-11e9-9bc4-95b67b4e72c6.png) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services