From commits-return-977-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Thu May 9 04:12:35 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 558E5180630 for ; Thu, 9 May 2019 06:12:35 +0200 (CEST) Received: (qmail 68430 invoked by uid 500); 9 May 2019 04:12:34 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 68420 invoked by uid 99); 9 May 2019 04:12:34 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 May 2019 04:12:34 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] adriancole commented on issue #2573: Uses okio/moshi natively in Elasticsearch everywhere Message-ID: <155737515437.28550.1972130898123245096.gitbox@gitbox.apache.org> Date: Thu, 09 May 2019 04:12:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on issue #2573: Uses okio/moshi natively in Elasticsearch everywhere URL: https://github.com/apache/incubator-zipkin/pull/2573#issuecomment-490736361 I ran a 5m load test against before and after. As it is, this doesn't make a big difference, likely because by default under load senders will produce 3MiB or so json per message. This will still result in big arrays. OTOH, we now have a chance to optimize. the left hand side is before and the right hand side is with this change. The test is brave-webmvc-example against zipkin+elasticsearch 6.7 for 5 minutes ![Screen Shot 2019-05-09 at 12 08 03 PM](https://user-images.githubusercontent.com/64215/57426825-9dfd8380-7253-11e9-9587-ae4df18d9356.png) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services