From commits-return-966-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Wed May 8 13:44:44 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 36963180630 for ; Wed, 8 May 2019 15:44:44 +0200 (CEST) Received: (qmail 27126 invoked by uid 500); 8 May 2019 13:44:43 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 27117 invoked by uid 99); 8 May 2019 13:44:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 May 2019 13:44:43 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] adriancole commented on issue #2563: Add a netty scribe server. Message-ID: <155732307854.14038.642497238064899932.gitbox@gitbox.apache.org> Date: Wed, 08 May 2019 13:44:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on issue #2563: Add a netty scribe server. URL: https://github.com/apache/incubator-zipkin/pull/2563#issuecomment-490491129 ps whenever this is ready for next look, I will test again using finagle, except using our libthrift impl [1] instead of finagle's native one. This will reduce the amount of variables around socket resets. [1] ours, but with this socket reset fix https://github.com/apache/incubator-zipkin-reporter-java/pull/143 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services