From commits-return-959-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Wed May 8 13:03:08 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3D05D180630 for ; Wed, 8 May 2019 15:03:08 +0200 (CEST) Received: (qmail 24671 invoked by uid 500); 8 May 2019 13:03:07 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 24661 invoked by uid 99); 8 May 2019 13:03:07 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 May 2019 13:03:07 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] adriancole commented on issue #2571: Backfills functional test of Scribe Message-ID: <155732058676.10102.15210046893075799372.gitbox@gitbox.apache.org> Date: Wed, 08 May 2019 13:03:06 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on issue #2571: Backfills functional test of Scribe URL: https://github.com/apache/incubator-zipkin/pull/2571#issuecomment-490476992 this test isn't good enough. our sender code had a problem in it (not sure if finagle's has a similar problem or not) https://github.com/apache/incubator-zipkin-reporter-java/pull/143 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services