From commits-return-905-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Wed May 8 07:06:58 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9EB82180630 for ; Wed, 8 May 2019 09:06:57 +0200 (CEST) Received: (qmail 14924 invoked by uid 500); 8 May 2019 07:06:57 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 14912 invoked by uid 99); 8 May 2019 07:06:57 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 May 2019 07:06:57 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] adriancole commented on a change in pull request #2570: Ports all zipkin-server tests to Kotlin Message-ID: <155729921692.7409.3166899980742768956.gitbox@gitbox.apache.org> Date: Wed, 08 May 2019 07:06:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit adriancole commented on a change in pull request #2570: Ports all zipkin-server tests to Kotlin URL: https://github.com/apache/incubator-zipkin/pull/2570#discussion_r281937945 ########## File path: zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java ########## @@ -185,6 +185,10 @@ static void maybeLog(String prefix, ServiceRequestContext ctx, AggregatedHttpMes } if (content.isEmpty()) ZipkinHttpCollector.maybeLog("Empty POST body", ctx, request); + if (content.length() == 2 && "[]".equals(content.toStringAscii())) { Review comment: found a bug while doing this!! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services