From commits-return-854-archive-asf-public=cust-asf.ponee.io@zipkin.apache.org Tue May 7 07:18:09 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 60FD518064C for ; Tue, 7 May 2019 09:18:09 +0200 (CEST) Received: (qmail 13902 invoked by uid 500); 7 May 2019 07:18:08 -0000 Mailing-List: contact commits-help@zipkin.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@zipkin.apache.org Delivered-To: mailing list commits@zipkin.apache.org Received: (qmail 13893 invoked by uid 99); 7 May 2019 07:18:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 May 2019 07:18:08 +0000 From: GitBox To: commits@zipkin.apache.org Subject: [GitHub] [incubator-zipkin] anuraaga opened a new pull request #2563: Add a netty scribe server. Message-ID: <155721348873.4745.9759804206668766170.gitbox@gitbox.apache.org> Date: Tue, 07 May 2019 07:18:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit anuraaga opened a new pull request #2563: Add a netty scribe server. URL: https://github.com/apache/incubator-zipkin/pull/2563 Fixes #2461 This currently adds a TCP server which reads thrift framed transport (https://github.com/facebookarchive/scribe/wiki/Logging-Messages indicates scribe uses thrift framed transport) and creates synthetic HTTP requests with the frames and serves them with armeria's thrift service. I haven't really tried the code out since it's not complete. The final step is to actually implement the Scribe thrift service, and while we already have the business logic, to remove swift we need to instead include scribe's thrift compiler generated code. @adriancole what do you think would be a good way of adding that? /cc @trustin for any thoughts on this approach ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services