zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] tmichnik1981 opened a new issue #2619: Calls server to client not visible on 'Dependencies' tree
Date Fri, 31 May 2019 13:24:33 GMT
tmichnik1981 opened a new issue #2619: Calls  server to client not visible on 'Dependencies'
tree 
URL: https://github.com/apache/incubator-zipkin/issues/2619
 
 
   zipkin: 2.12.9
   
   I prepared 2 short tests for zipkin2.internal.DependencyLinker for better understanding
what I mean.
   
   In both cases, links **server -> client1** are missing.  I there  something wrong with
my entry data or tests? 
   
   ```
     @Test
     public void shouldServerClientRemoteCallsWithServerDescendantBuildLinks() {
       List<Span> trace = asList(
         span2("a", null, "a", Kind.CLIENT, "client0", null, false),
         span2("a", "a", "b", Kind.SERVER, "server", "client0", false),
         span2("a", "b", "c", Kind.CLIENT, "client1", null, false),
         span2("a", "c", "d", Kind.SERVER, "server1", "client1", false)
       );
   
       assertThat(new DependencyLinker().putTrace(trace).link()).contains(
         DependencyLink.newBuilder().parent("client0").child("server").callCount(1L).build(),
         DependencyLink.newBuilder().parent("server").child("client1").callCount(1L).build(),
         DependencyLink.newBuilder().parent("client1").child("server1").callCount(1L).build()
       );
     }
   
     @Test
     public void shouldServerClientRemoteCallsWithClientDescendantBuildLinks() {
       List<Span> trace = asList(
         span2("a", null, "a", Kind.CLIENT, "client0", null, false),
         span2("a", "a", "b", Kind.SERVER, "server", "client0", false),
         span2("a", "b", "c", Kind.CLIENT, "client1", null, false),
         span2("a", "c", "d", Kind.CLIENT, "client2", null, false)
       );
   
       assertThat(new DependencyLinker().putTrace(trace).link()).contains(
         DependencyLink.newBuilder().parent("client0").child("server").callCount(1L).build(),
         DependencyLink.newBuilder().parent("server").child("client1").callCount(1L).build(),
         DependencyLink.newBuilder().parent("client1").child("client2").callCount(1L).build()
       );
     }
   
   ```
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message