zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2618: [zipin-lens] Fix #2615: Bundle Fontawesome into the app
Date Wed, 29 May 2019 07:46:40 GMT
adriancole commented on issue #2618: [zipin-lens] Fix #2615: Bundle Fontawesome into the app
URL: https://github.com/apache/incubator-zipkin/pull/2618#issuecomment-496824831
 
 
   @devinsba as we aren't adding fontawesome to the source tree (vendoring like we did in
zipkin-ui), and what we are verifying is a source distribution, not a binary one.. we don't
need to add to the LICENSE file (FWIW I added notes about vendored files to DISCLAIMER once
and was told to move them to LICENSE as DISCLAIMER is about us being not a real ASF project
yet).
   
   https://github.com/apache/incubator-zipkin/issues/2548 should be the one for fontawesome
and other things that are dependencies in the lens build iiuc. IOTW, DEPENDENCIES is the drone
you're looking for

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message