zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] tacigar commented on issue #2613: [WIP] Refactor global search component
Date Wed, 29 May 2019 05:44:36 GMT
tacigar commented on issue #2613: [WIP] Refactor global search component
URL: https://github.com/apache/incubator-zipkin/pull/2613#issuecomment-496793009
 
 
   We use **React-Select** in GlobalSearch component.
   
   React-select is a nice component library.
   But, I think it is unsuitable for usage like GlobalSearch in the following points.
   
   * In GlobalSearch, react-select's style needs to be modified a lot for design. I think
it is not a beautiful way.
   * As mentioned in #2485 , we want to display the dropdown menu more rich, but it seems
impossible by using react-select.
   * I want to control **focus** completely for providing more intuitive operation, but react-select
black-boxes focus a bit...
   
   So, I want to create a new **Select** component.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message