zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] abesto commented on a change in pull request #2618: [zipin-lens] Fix #2615: Bundle Fontawesome into the app
Date Tue, 28 May 2019 22:37:09 GMT
abesto commented on a change in pull request #2618: [zipin-lens] Fix #2615: Bundle Fontawesome
into the app
URL: https://github.com/apache/incubator-zipkin/pull/2618#discussion_r288329408
 
 

 ##########
 File path: zipkin-lens/static/index.html
 ##########
 @@ -21,7 +21,6 @@
   <head>
     <base href="/" />
     <meta charset="utf-8">
-    <link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.4.1/css/all.css"
integrity="sha384-5sAR7xN1Nv6T6+dT2mhtzEpVJvfS3NScPQTrOxhwjIuvcA67KV2R5Jz6kr4abQsz" crossorigin="anonymous">
 
 Review comment:
   Bye-bye fonts loaded from the internets!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message