zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] abesto commented on a change in pull request #2618: [zipin-lens] Fix #2615: Bundle Fontawesome into the app
Date Tue, 28 May 2019 22:23:15 GMT
abesto commented on a change in pull request #2618: [zipin-lens] Fix #2615: Bundle Fontawesome
into the app
URL: https://github.com/apache/incubator-zipkin/pull/2618#discussion_r288325771
 
 

 ##########
 File path: zipkin-lens/webpack.prod.config.js
 ##########
 @@ -40,24 +46,12 @@ module.exports = {
       },
       {
         test: /\.scss$/,
-        use: ExtractTextPlugin.extract({
-          fallback: 'style-loader',
-          use: [
-            {
-              loader: 'css-loader',
-              options: {
-                url: false,
-                sourceMap: true,
-              },
-            },
-            {
-              loader: 'sass-loader',
-              options: {
-                sourceMap: true,
-              },
-            },
-          ],
-        }),
+        use: [
+          { loader: MiniCssExtractPlugin.loader },
+          { loader: 'css-loader', options: { sourceMap: true } },
+          { loader: 'resolve-url-loader' },
 
 Review comment:
   This is needed for some magical Webpack path wrangling that, I'll admit, I only mostly
understand. Either way, it makes the site go. Something along the lines of: it replaces `~@fortawesome/...woff2`
with wherever the files end up in the actual output.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message