zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2616: Not all client to client relations taken into account in 'Dependencies' tree
Date Tue, 28 May 2019 14:27:22 GMT
adriancole commented on issue #2616: Not all client to client relations taken into account
in 'Dependencies' tree 
URL: https://github.com/apache/incubator-zipkin/issues/2616#issuecomment-496540456
 
 
   ps looking at your data span 076fecc8a861e28e, I think localEndpoint.serviceName ="auth"
should have been remoteEndpoint.serviceName= "auth" if in the same process.
   
   you could make the case that a child span of a client that is an incidental request could
make another link to an uninstrumented service.. just it would need to be a link to the service
identified as remoteEndpoint.serviceName. localEndpoint.serviceName should be constant for
the local call tree starting with the inbound server request. IOTW I think there is a little
bit of things in the wrong spot. Does that make sense?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message