zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] anuraaga commented on a change in pull request #2611: Handle exceptions without message.
Date Tue, 28 May 2019 05:32:21 GMT
anuraaga commented on a change in pull request #2611: Handle exceptions without message.
URL: https://github.com/apache/incubator-zipkin/pull/2611#discussion_r287934864
 
 

 ##########
 File path: zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java
 ##########
 @@ -235,13 +235,19 @@ static HttpData convertRequest(ServiceRequestContext ctx, AggregatedHttpMessage
 
 final class BodyIsExceptionMessage implements ExceptionHandlerFunction {
 
+  static final Logger LOGGER = LogManager.getLogger();
+
   @Override
   public HttpResponse handleException(RequestContext ctx, HttpRequest req, Throwable cause)
{
     ZipkinHttpCollector.metrics.incrementMessagesDropped();
+
+    LOGGER.warn("Unexpected error handling request.", cause);
 
 Review comment:
   Good point, moved the logging so it's for cases that aren't bad requests, which we probably
do need to see for debugging issues.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message