zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] shakuzen commented on a change in pull request #2611: Handle exceptions without message.
Date Mon, 27 May 2019 12:18:41 GMT
shakuzen commented on a change in pull request #2611: Handle exceptions without message.
URL: https://github.com/apache/incubator-zipkin/pull/2611#discussion_r287767892
 
 

 ##########
 File path: zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java
 ##########
 @@ -235,13 +235,19 @@ static HttpData convertRequest(ServiceRequestContext ctx, AggregatedHttpMessage
 
 final class BodyIsExceptionMessage implements ExceptionHandlerFunction {
 
+  static final Logger LOGGER = LogManager.getLogger();
+
   @Override
   public HttpResponse handleException(RequestContext ctx, HttpRequest req, Throwable cause)
{
     ZipkinHttpCollector.metrics.incrementMessagesDropped();
+
+    LOGGER.warn("Unexpected error handling request.", cause);
 
 Review comment:
   I'm not sure we want to add this logging in all cases. It seems too verbose to me for bad
requests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message