zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] trustin commented on a change in pull request #2604: Moves to Armeria 0.86
Date Sat, 18 May 2019 07:38:17 GMT
trustin commented on a change in pull request #2604: Moves to Armeria 0.86
URL: https://github.com/apache/incubator-zipkin/pull/2604#discussion_r285332803
 
 

 ##########
 File path: zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java
 ##########
 @@ -213,7 +214,7 @@ static HttpData convertRequest(ServiceRequestContext ctx, AggregatedHttpMessage
     String encoding = request.headers().get(HttpHeaderNames.CONTENT_ENCODING);
     HttpData content = request.content();
     if (!content.isEmpty() && encoding != null && encoding.contains("gzip"))
{
-      content = GZIP_DECODER_FACTORY.newDecoder().decode(content);
+      content = GZIP_DECODER_FACTORY.newDecoder(ByteBufAllocator.DEFAULT).decode(content);
 
 Review comment:
   You can use ctx.alloc() 😄 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message