zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2596: Try to downsize a little
Date Wed, 15 May 2019 14:10:42 GMT
adriancole commented on issue #2596: Try to downsize a little
URL: https://github.com/apache/incubator-zipkin/issues/2596#issuecomment-492671284
 
 
   I looked at some suspicious once.. jsoup is 400K and deals with something that seems normal
string replacement should work out. Basically, we should be able to control our index.html
generation in lens and ui to always emit the base tag, eliminating this logic: https://github.com/apache/incubator-zipkin/blob/master/zipkin-server/src/main/java/zipkin2/server/internal/ui/ZipkinUiConfiguration.java#L116-L120
   
   then, the replacement here should be normal string replacement.
   
   Note: I just checked and here is the base tag in our two UIs
   zipkin-ui: `<base href="/zipkin/">`
   zipkin-lens: `<base href=/ />`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message