zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2595: Decode ByteBuffer directly where possible.
Date Wed, 15 May 2019 12:42:50 GMT
adriancole commented on issue #2595: Decode ByteBuffer directly where possible.
URL: https://github.com/apache/incubator-zipkin/pull/2595#issuecomment-492638221
 
 
   I compared this against the last release (2.13) running the same load test:11K span/second
in 2 proto messages/second decode only (aka COLLECTOR_SAMPLE_RATE=0)
   
   Before:
   <img width="962" alt="Screen Shot 2019-05-15 at 2 39 16 PM" src="https://user-images.githubusercontent.com/64215/57776317-bbe64f00-7751-11e9-8f60-bc24e9545f93.png">
   
   Now:
   <img width="969" alt="Screen Shot 2019-05-15 at 2 30 16 PM" src="https://user-images.githubusercontent.com/64215/57776325-bee13f80-7751-11e9-9469-0300a463e6ed.png">
   
   while this is not the only change involved, overall there's a heck of a lot less GC activity.
bravo!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message