zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on a change in pull request #2595: Decode ByteBuffer directly where possible.
Date Wed, 15 May 2019 11:53:14 GMT
adriancole commented on a change in pull request #2595: Decode ByteBuffer directly where possible.
URL: https://github.com/apache/incubator-zipkin/pull/2595#discussion_r284216589
 
 

 ##########
 File path: zipkin-server/src/main/java/zipkin2/server/internal/ZipkinHttpCollector.java
 ##########
 @@ -139,7 +139,7 @@ HttpResponse validateAndStoreSpans(SpanBytesDecoder decoder, ServiceRequestConte
         } else {
           // Currently this will happen for gzip spans. Need to fix armeria's gzip decoder
to allow
           // returning pooled buffers on request.
-          nioBuffer = ByteBuffer.wrap(content.array());
+          nioBuffer = ByteBuffer.wrap(content.array(), content.offset(), content.length());
 
 Review comment:
   good eye :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message