zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2592: Add benchmark of jackson span decoder.
Date Wed, 15 May 2019 08:58:54 GMT
adriancole commented on issue #2592: Add benchmark of jackson span decoder.
URL: https://github.com/apache/incubator-zipkin/pull/2592#issuecomment-492569002
 
 
   basically our json decoders validate fields, so for example, there aren't as many rules
we need to follow. For example, none of our numeric types are decimal or valid in exponent
form, none of our field names are non-ascii, our deepest valid depth is 3, etc. With the constraints
in mind, it could be done.. just I spent too much time porting tests.. one of those things
to slowly do over time :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message