zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2589: Makes SpanBytesDecoder work on ByteBuffer
Date Mon, 13 May 2019 00:36:49 GMT
adriancole commented on issue #2589: Makes SpanBytesDecoder work on ByteBuffer
URL: https://github.com/apache/incubator-zipkin/pull/2589#issuecomment-491642768
 
 
   here are relative read comparisons. clearly if someone wants most efficient client and
server side, they should switch to proto3. I'm not sure the end to end on http+proto3 vs grpc,
but I suspect either will be less overhead.
   
   cc @dio @apache/zipkin-committers 
   
   ```
   CodecBenchmarks.readChineseSpan_JSON_V1:readChineseSpan_JSON_V1·p0.99     sample     
       19.232             us/op
   CodecBenchmarks.readChineseSpan_JSON_V1:·gc.alloc.rate.norm               sample     
15  18879.162 ±  77.971    B/op
   CodecBenchmarks.readChineseSpan_JSON_V2:readChineseSpan_JSON_V2·p0.99     sample     
       13.488             us/op
   CodecBenchmarks.readChineseSpan_JSON_V2:·gc.alloc.rate.norm               sample     
15  13976.995 ±   0.076    B/op
   CodecBenchmarks.readChineseSpan_PROTO3:readChineseSpan_PROTO3·p0.99       sample     
        2.892             us/op
   CodecBenchmarks.readChineseSpan_PROTO3:·gc.alloc.rate.norm                sample     
15   2154.954 ±  20.872    B/op
   CodecBenchmarks.readChineseSpan_THRIFT:readChineseSpan_THRIFT·p0.99       sample     
       11.423             us/op
   CodecBenchmarks.readChineseSpan_THRIFT:·gc.alloc.rate.norm                sample     
15   5805.938 ±  41.742    B/op
   CodecBenchmarks.readClientSpan_JSON_V1:readClientSpan_JSON_V1·p0.99       sample     
       18.720             us/op
   CodecBenchmarks.readClientSpan_JSON_V1:·gc.alloc.rate.norm                sample     
15  19887.021 ±  33.413    B/op
   CodecBenchmarks.readClientSpan_JSON_V2:readClientSpan_JSON_V2·p0.99       sample     
       13.680             us/op
   CodecBenchmarks.readClientSpan_JSON_V2:·gc.alloc.rate.norm                sample     
15  14345.030 ±   0.083    B/op
   CodecBenchmarks.readClientSpan_PROTO3:readClientSpan_PROTO3·p0.99         sample     
        2.046             us/op
   CodecBenchmarks.readClientSpan_PROTO3:·gc.alloc.rate.norm                 sample     
15   1744.276 ±   0.020    B/op
   CodecBenchmarks.readClientSpan_THRIFT:readClientSpan_THRIFT·p0.99         sample     
        8.608             us/op
   CodecBenchmarks.readClientSpan_THRIFT:·gc.alloc.rate.norm                 sample     
15   5065.300 ± 188.452    B/op
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message