zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2589: Makes SpanBytesDecoder work on ByteBuffer
Date Sun, 12 May 2019 11:13:10 GMT
adriancole commented on issue #2589: Makes SpanBytesDecoder work on ByteBuffer
URL: https://github.com/apache/incubator-zipkin/pull/2589#issuecomment-491586323
 
 
   With this change, our decoder is significantly faster and GC efficient also with bytebuffer.
   
   ```
   ProtoCodecBenchmarks.bytebuffer_protobufDecoder:bytebuffer_protobufDecoder·p0.99    sample
           2232.320                us/op
   ProtoCodecBenchmarks.bytebuffer_protobufDecoder:·gc.alloc.rate.norm                 sample
    15  2023331.587 ±     39.087    B/op
   ProtoCodecBenchmarks.bytebuffer_wireDecoder:bytebuffer_wireDecoder·p0.99            sample
           2330.624                us/op
   ProtoCodecBenchmarks.bytebuffer_wireDecoder:·gc.alloc.rate.norm                     sample
    15  2435472.372 ±     54.488    B/op
   ProtoCodecBenchmarks.bytebuffer_zipkinDecoder:bytebuffer_zipkinDecoder·p0.99        sample
           1964.032                us/op
   ProtoCodecBenchmarks.bytebuffer_zipkinDecoder:·gc.alloc.rate.norm                   sample
    15  1735287.795 ±     34.431    B/op
   ProtoCodecBenchmarks.bytes_protobufDecoder:bytes_protobufDecoder·p0.99              sample
           1949.696                us/op
   ProtoCodecBenchmarks.bytes_protobufDecoder:·gc.alloc.rate.norm                      sample
    15  2023208.424 ±     43.028    B/op
   ProtoCodecBenchmarks.bytes_wireDecoder:bytes_wireDecoder·p0.99                      sample
           2360.566                us/op
   ProtoCodecBenchmarks.bytes_wireDecoder:·gc.alloc.rate.norm                          sample
    15  2435409.404 ±     48.839    B/op
   ProtoCodecBenchmarks.bytes_zipkinDecoder:bytes_zipkinDecoder·p0.99                  sample
           1810.596                us/op
   ProtoCodecBenchmarks.bytes_zipkinDecoder:·gc.alloc.rate.norm                        sample
    15  1735156.400 ±     30.538    B/op
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message