zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2584: Adds cheap string encoding for IpV4 path used in protobuf
Date Sat, 11 May 2019 09:14:40 GMT
adriancole commented on issue #2584: Adds cheap string encoding for IpV4 path used in protobuf
URL: https://github.com/apache/incubator-zipkin/pull/2584#issuecomment-491494517
 
 
   my laptop isn't as fast as @anuraaga's :)
   
   before:
   ```
   EndpointBenchmarks.parseIpv4_bytes:parseIpv4_bytes·p0.99             sample          
  0.360             us/op
   EndpointBenchmarks.parseIpv4_bytes:·gc.alloc.rate.norm               sample      15  
184.015 ±   0.001    B/op
   
   ProtoCodecBenchmarks.bytes_zipkinDecoder:bytes_zipkinDecoder·p0.99         sample    
       2078.024               us/op
   ProtoCodecBenchmarks.bytes_zipkinDecoder:·gc.alloc.rate.norm               sample    
15  2191141.794 ±    45.769    B/op
   ```
   
   after:
   ```
   EndpointBenchmarks.parseIpv4_bytes:parseIpv4_bytes·p0.99             sample          
  0.281             us/op
   EndpointBenchmarks.parseIpv4_bytes:·gc.alloc.rate.norm               sample      15  
 88.011 ±   0.005    B/op
   
   ProtoCodecBenchmarks.bytes_zipkinDecoder:bytes_zipkinDecoder·p0.99         sample    
       2043.392               us/op
   ProtoCodecBenchmarks.bytes_zipkinDecoder:·gc.alloc.rate.norm               sample    
15  2095169.988 ±    32.752    B/op
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message