zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2582: Reuse char[] buffer when decoding hex fields.
Date Sat, 11 May 2019 07:18:05 GMT
adriancole commented on issue #2582: Reuse char[] buffer when decoding hex fields.
URL: https://github.com/apache/incubator-zipkin/pull/2582#issuecomment-491487029
 
 
   whoah I was wrong :) all the hex code in Span is used directly by brave...
   
   ex.
   ```java
       Span.Builder builderWithContextData = Span.newBuilder()
           .traceId(context.traceIdString())
           .parentId(context.parentIdString())
           .id(context.spanIdString());
   ```
   
   so I think if this is changed similarly, it will reduce allocations measurably on traced
apps!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message