zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2502: Adding storage-throttle module to address "over capacity" issues
Date Fri, 10 May 2019 23:58:28 GMT
adriancole commented on issue #2502: Adding storage-throttle module to address "over capacity"
issues
URL: https://github.com/apache/incubator-zipkin/pull/2502#issuecomment-491460316
 
 
   What you did was great, and in fact I found some problems in how many of
   our implementations implement call as a result of this, so double win!
   cheers
   
   On Sat, May 11, 2019 at 12:02 AM Logic-32 <notifications@github.com> wrote:
   
   > *@Logic-32* commented on this pull request.
   > ------------------------------
   >
   > In
   > zipkin-server/src/main/java/zipkin2/server/internal/elasticsearch/ZipkinElasticsearchStorageProperties.java
   > <https://github.com/apache/incubator-zipkin/pull/2502#discussion_r282945074>
   > :
   >
   > > @@ -64,8 +64,9 @@
   >     */
   >    private int timeout = 10_000;
   >
   > -  public ZipkinElasticsearchStorageProperties(@Value("${zipkin.storage.throttle.enabled:false}")
boolean throttleEnabled,
   > -                                              @Value("${zipkin.storage.throttle.maxConcurrency:200}")
int throttleMaxConcurrency) {
   > +  ZipkinElasticsearchStorageProperties(
   > +    @Value("${zipkin.storage.throttle.enabled:false}") boolean throttleEnabled,
   > +    @Value("${zipkin.storage.throttle.maxConcurrency:200}") int throttleMaxConcurrency)
{
   >
   > Kk. Thank you for finishing this up and sorry again for the lag on my end!
   > Work got in the way :(
   >
   > —
   > You are receiving this because you modified the open/close state.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-zipkin/pull/2502#discussion_r282945074>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAAPVV5JF2LL2N455DWF2XDPUWL75ANCNFSM4HGYQFGQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message