zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] Logic-32 commented on a change in pull request #2580: Makes it an error to store during assembly of a call
Date Fri, 10 May 2019 15:58:55 GMT
Logic-32 commented on a change in pull request #2580: Makes it an error to store during assembly
of a call
URL: https://github.com/apache/incubator-zipkin/pull/2580#discussion_r282943943
 
 

 ##########
 File path: zipkin-server/src/main/java/zipkin2/server/internal/throttle/ThrottledCall.java
 ##########
 @@ -153,17 +126,17 @@ static String setCurrentThreadName(String name) {
 
   final class QueuedCall implements Runnable {
 
 Review comment:
   Can this be `static` now?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message