zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2579: Benchmark bytes / bytebuffer, protobuf vs zipkin vs wire.
Date Fri, 10 May 2019 14:45:05 GMT
adriancole commented on issue #2579: Benchmark bytes / bytebuffer, protobuf vs zipkin vs wire.
URL: https://github.com/apache/incubator-zipkin/pull/2579#issuecomment-491314676
 
 
   PS @anuraaga I think the context you mention which is there are optimizations on the server
that would be different than android-focused libraries is certainly spot-on. We shouldn't
prevent ourselves from taking advantage of these optimizations considering this is server
code.
   
   I do remember some discussions last time about the guava sensitivity and heft of google
libraries (ex. protobuf-java is 2MiB). I'm not super keen to re-enter that at the moment,
but there could be some sense in using an unsafe mechanism such as they are.
   
   At any rate, I learned thought this work that there's actually a measurable amount of gc
time to recover. Eventhough I mentioned a little less priority, that's my personal 2p, if
you are interested in taking the "attack the overhead" issue forward, please continue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message