zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on a change in pull request #2502: Adding storage-throttle module to address "over capacity" issues
Date Fri, 10 May 2019 14:23:39 GMT
adriancole commented on a change in pull request #2502: Adding storage-throttle module to address
"over capacity" issues
URL: https://github.com/apache/incubator-zipkin/pull/2502#discussion_r282905755
 
 

 ##########
 File path: zipkin-server/src/main/java/zipkin2/server/internal/elasticsearch/ZipkinElasticsearchStorageProperties.java
 ##########
 @@ -64,8 +64,9 @@
    */
   private int timeout = 10_000;
 
-  public ZipkinElasticsearchStorageProperties(@Value("${zipkin.storage.throttle.enabled:false}")
boolean throttleEnabled,
-                                              @Value("${zipkin.storage.throttle.maxConcurrency:200}")
int throttleMaxConcurrency) {
+  ZipkinElasticsearchStorageProperties(
+    @Value("${zipkin.storage.throttle.enabled:false}") boolean throttleEnabled,
+    @Value("${zipkin.storage.throttle.maxConcurrency:200}") int throttleMaxConcurrency) {
 
 Review comment:
   shouldn't be required, but it is nice to do this. good catch
   
   (ps I'm knackered so will deal with the other PR and any comments in the morning)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message