zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] anuraaga commented on issue #2579: Benchmark bytes / bytebuffer, protobuf vs zipkin vs wire.
Date Fri, 10 May 2019 13:30:02 GMT
anuraaga commented on issue #2579: Benchmark bytes / bytebuffer, protobuf vs zipkin vs wire.
URL: https://github.com/apache/incubator-zipkin/pull/2579#issuecomment-491289168
 
 
   Yup using Unsafe is probably the biggest difference and in the Armeria case it would end
up in the Unsafe path if we so choose. From what I understand, wire / okio is mostly for Android,
so it wouldn't make sense for them to implement support for Unsafe which doesn't work there.
Protobuf had to support calling Java from C++... but interestingly the optimizations that
went into doing that do apply to Netty-based servers too like here since they use direct memory.
   
   I'm personally leaning towards not changing anything at this point though since for single
digit gains, having two parser implementations seems like it's not worth it. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message