zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2579: Benchmark bytes / bytebuffer, protobuf vs zipkin vs wire.
Date Fri, 10 May 2019 12:51:38 GMT
adriancole commented on issue #2579: Benchmark bytes / bytebuffer, protobuf vs zipkin vs wire.
URL: https://github.com/apache/incubator-zipkin/pull/2579#issuecomment-491277694
 
 
   one thing I was thinking about in this change is that when you are ultimately backed by
an array, google sneakily looks to see if that's the case and special cases accordingly.
   
   When we have an array is unlikely something we'd optimize for in the grpc listener. I'm
wondering if we can get a more realistic source like what armeria would be using and apply
that to the bytebuffer (or otherwise) case...
   
   PS I also looked at wire and started to play with inlining a hex utility.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message