zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2579: Benchmark bytes / bytebuffer, protobuf vs zipkin vs wire.
Date Fri, 10 May 2019 09:09:17 GMT
adriancole commented on issue #2579: Benchmark bytes / bytebuffer, protobuf vs zipkin vs wire.
URL: https://github.com/apache/incubator-zipkin/pull/2579#issuecomment-491218518
 
 
   PS some background always helps...
   
   our core library includes a dependency free codec. I think this is still important eventhough
the parsing side is less so (it does help in wonky huge dep clash environments like spark)
   
   in our server, we have some flexibility, and to that end I was thinking about having the
ability to override the codecs towards your initial issue #2435. When I started optimizing
the Elasticsearch side, I noticed that our v2 format is so easy now, even converting from
a codec-specific type like proto.span *is still cheaper* than us doing it directly for some
reasons you mentioned.  While using google's proto library would re-introduce their version
thrash I do like doing comparisons. I've thought most about wire as that is so incredibly
more efficient than ours, and it has no notable deps we don't already depend on.
   
   Thanks for doing this comparison!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message