zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] tacigar commented on a change in pull request #2577: Change file suffix .js to .jsx
Date Fri, 10 May 2019 04:24:22 GMT
tacigar commented on a change in pull request #2577: Change file suffix .js to .jsx
URL: https://github.com/apache/incubator-zipkin/pull/2577#discussion_r282742335
 
 

 ##########
 File path: zipkin-lens/src/components/Browser/index.js
 ##########
 @@ -14,59 +14,4 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
-import PropTypes from 'prop-types';
-import React from 'react';
-
-import { sortingMethods } from './sorting';
-import BrowserHeader from './BrowserHeader';
-import BrowserResults from './BrowserResults';
-import LoadingOverlay from '../Common/LoadingOverlay';
-import { traceSummariesPropTypes } from '../../prop-types';
-
-const propTypes = {
-  traceSummaries: traceSummariesPropTypes.isRequired,
-  tracesMap: PropTypes.shape({}).isRequired,
-  isLoading: PropTypes.bool.isRequired,
-  clearTraces: PropTypes.func.isRequired,
-};
-
-class Browser extends React.Component {
-  constructor(props) {
-    super(props);
-    this.state = { sortingMethod: sortingMethods.LONGEST };
-    this.handleSortingMethodChange = this.handleSortingMethodChange.bind(this);
-  }
-
-  componentWillUnmount() {
-    const { clearTraces } = this.props;
-    clearTraces();
-  }
-
-  handleSortingMethodChange(selected) {
-    this.setState({ sortingMethod: selected.value });
-  }
-
-  render() {
-    const { isLoading, traceSummaries, tracesMap } = this.props;
-    const { sortingMethod } = this.state;
-    return (
-      <div className="browser">
-        <LoadingOverlay active={isLoading} />
-        <BrowserHeader
-          numTraces={traceSummaries.length}
-          sortingMethod={sortingMethod}
-          onChange={this.handleSortingMethodChange}
-        />
-        <BrowserResults
-          traceSummaries={traceSummaries}
-          sortingMethod={sortingMethod}
-          tracesMap={tracesMap}
-        />
-      </div>
-    );
-  }
-}
-
-Browser.propTypes = propTypes;
-
-export default Browser;
 
 Review comment:
   The above code is moved to `Browser.jsx`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message