zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2502: Adding storage-throttle module to address "over capacity" issues
Date Thu, 09 May 2019 23:33:15 GMT
adriancole commented on issue #2502: Adding storage-throttle module to address "over capacity"
issues
URL: https://github.com/apache/incubator-zipkin/pull/2502#issuecomment-491103156
 
 
   hi. I dont think delaying more is good because it is distracting and
   subject to drift which effects us more than the minor points mentioned.
   
   since this is disabled by default and mentioned as experimental I think it
   is better to not let best be the enemy of good.
   
   I will merge this so folks can test it in 2.14. thanks for the help
   championing this Craig!
   
   On Fri, May 10, 2019, 3:35 AM Logic-32 <notifications@github.com> wrote:
   
   > Thanks! If I can't get to the additional feedback tomorrow I'll get to it
   > early next week. Sorry for being sluggish but at least it gives people time
   > to test :)
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-zipkin/pull/2502#issuecomment-491036886>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAAPVV4OKRJOEKWXULY5BPTPUR4GNANCNFSM4HGYQFGQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message