zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-reporter-java] adriancole commented on a change in pull request #143: Fixes socket reset problem in libthrift sender
Date Wed, 08 May 2019 13:05:55 GMT
adriancole commented on a change in pull request #143: Fixes socket reset problem in libthrift
sender
URL: https://github.com/apache/incubator-zipkin-reporter-java/pull/143#discussion_r282056615
 
 

 ##########
 File path: libthrift/src/main/java/zipkin2/reporter/libthrift/InternalScribeCodec.java
 ##########
 @@ -78,15 +78,17 @@ public static boolean readLogResponse(int seqid, TBinaryProtocol iprot)
throws T
   }
 
   static boolean parseResponse(TBinaryProtocol iprot) throws TException {
+    Boolean result = null;
     iprot.readStructBegin();
     TField schemeField;
     while ((schemeField = iprot.readFieldBegin()).type != TType.STOP) {
       if (schemeField.id == 0 /* SUCCESS */ && schemeField.type == TType.I32) {
-        return iprot.readI32() == 0;
 
 Review comment:
   this early return would leave the message partially read. FB swift would get angry and
reset the socket when this is the case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message