zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin-reporter-java] adriancole commented on a change in pull request #143: Fixes socket reset problem in libthrift sender
Date Wed, 08 May 2019 13:05:08 GMT
adriancole commented on a change in pull request #143: Fixes socket reset problem in libthrift
sender
URL: https://github.com/apache/incubator-zipkin-reporter-java/pull/143#discussion_r282056379
 
 

 ##########
 File path: libthrift/src/test/java/zipkin2/reporter/libthrift/LibthriftSenderTest.java
 ##########
 @@ -68,6 +70,17 @@ public void sendsSpans() throws Exception {
     assertThat(storage.spanStore().getTraces()).containsExactly(asList(CLIENT_SPAN));
   }
 
+  /** This will help verify sequence ID and response parsing logic works */
+  @Test
+  public void sendsSpans_multipleTimes() throws Exception {
+    for (int i = 0; i < 5; i++) { // Have client send 5 messages
 
 Review comment:
   @trustin @anuraaga this would result in a hang on the third message, which eventually would
lead to a socket reset. The root cause was the client didn't fully consume the response from
the server (it now does)
   
   https://github.com/openzipkin/zipkin-finagle-example/compare/raw-finagle doesn't use the
code here, but it is possible a similar issue exists in finagle.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message