zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] anuraaga opened a new pull request #2563: Add a netty scribe server.
Date Tue, 07 May 2019 07:18:08 GMT
anuraaga opened a new pull request #2563: Add a netty scribe server.
URL: https://github.com/apache/incubator-zipkin/pull/2563
 
 
   Fixes #2461
   
   This currently adds a TCP server which reads thrift framed transport (https://github.com/facebookarchive/scribe/wiki/Logging-Messages
indicates scribe uses thrift framed transport) and creates synthetic HTTP requests with the
frames and serves them with armeria's thrift service.
   
   I haven't really tried the code out since it's not complete.
   
   The final step is to actually implement the Scribe thrift service, and while we already
have the business logic, to remove swift we need to instead include scribe's thrift compiler
generated code. @adriancole what do you think would be a good way of adding that?
   
   /cc @trustin for any thoughts on this approach

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message