zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2461: re-implement scribe over armeria
Date Tue, 07 May 2019 03:15:54 GMT
adriancole commented on issue #2461: re-implement scribe over armeria
URL: https://github.com/apache/incubator-zipkin/issues/2461#issuecomment-489891527
 
 
   yeah actually it is better that it is a different port (9410 is what a lot
   of things are pointed at)
   
   main thing is we are best if netty is aligned.
   
   On Tue, May 7, 2019 at 11:13 AM Anuraag Agrawal <notifications@github.com>
   wrote:
   
   > Is it ok for scribe to be a separate port? I guess it has to be if it's
   > not HTTP.
   >
   > If so, I think it's best to implement it directly as a Netty server on a
   > different port that can wrap TCP payloads into HTTP ones sent to the
   > standard endpoint on localhost.
   >
   > I found this implementation of thrift on Netty that seems to implement way
   > more than would be needed, but could be a reference.
   >
   >
   > https://github.com/airlift/drift/tree/master/drift-transport-netty/src/main/java/io/airlift/drift/transport/netty
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-zipkin/issues/2461#issuecomment-489891187>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAAPVV367QMC7CHBLFX7AN3PUDXXDANCNFSM4HADJNGQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message