zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] anuraaga commented on issue #2461: re-implement scribe over armeria
Date Tue, 07 May 2019 03:13:51 GMT
anuraaga commented on issue #2461: re-implement scribe over armeria
URL: https://github.com/apache/incubator-zipkin/issues/2461#issuecomment-489891187
 
 
   Is it ok for scribe to be a separate port? I guess it has to be if it's not HTTP.
   
   If so, I think it's best to implement it directly as a Netty server on a different port
that can wrap TCP payloads into HTTP ones sent to the standard endpoint on localhost.
   
   I found this implementation of thrift on Netty that seems to implement way more than would
be needed, but could be a reference.
   
   https://github.com/airlift/drift/tree/master/drift-transport-netty/src/main/java/io/airlift/drift/transport/netty

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message