zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on a change in pull request #2502: Adding storage-throttle module to address "over capacity" issues
Date Mon, 06 May 2019 23:33:45 GMT
adriancole commented on a change in pull request #2502: Adding storage-throttle module to address
"over capacity" issues
URL: https://github.com/apache/incubator-zipkin/pull/2502#discussion_r281403729
 
 

 ##########
 File path: zipkin-server/src/test/java/zipkin2/server/internal/throttle/FakeCall.java
 ##########
 @@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package zipkin2.server.internal.throttle;
+
+import java.io.IOException;
+import java.util.concurrent.RejectedExecutionException;
+import zipkin2.Call;
+import zipkin2.Callback;
+
+class FakeCall extends Call<Void> {
 
 Review comment:
   sorry inling was a poor choice of words. I meant nesting it into the same class as the
call site. You'll see a bunch of places where we do this. Ex `class Foo { static class Factory
{` If it is used in multiple classes then yeah it is fine to keep it separate.
   
   extending Call.Base was a suggestion to reduce the amount of code. Generally speaking less
untested code the better (ex we don't test the code in tests).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message