zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on issue #2398: Adds support for Elasticsearch 7.x
Date Mon, 06 May 2019 09:24:47 GMT
adriancole commented on issue #2398: Adds support for Elasticsearch 7.x
URL: https://github.com/apache/incubator-zipkin/pull/2398#issuecomment-489559710
 
 
   Custom index templates are not covered in the code here. Let's move to chat
   and help troubleshoot to the degree we can?
   https://gitter.im/openzipkin/zipkin
   
   On Mon, May 6, 2019 at 5:04 PM chefky <notifications@github.com> wrote:
   
   > Am trying to overwrite the one that you created, but I do this in Kibana,
   > after the default template has been created. Original tags field has
   > enabled = false, so I just run PUT _template/zipkin-span_template with
   > everything the same as default, except for the tags field. This is saved
   > successfully, but the next time I run my test program and new spans are
   > created, I get the merge conflict. Since this was working in previous
   > versions, I thought zipkin checked for existing templates and did nothing
   > if one was found.
   >
   > On the side note : I need to track specific error codes as we have some
   > exceptions (e.g. 4XX codes, as well as 503, do not affect success rate)
   >
   >
   > On Mon, May 6, 2019 at 4:35 PM Adrian Cole <notifications@github.com>
   > wrote:
   >
   > > are you saying you have a secondary index template and are trying to
   > merge
   > > this with the one we create?
   > >
   > > aside: conventionally we add the tag error when http status is error
   > >
   > > On Mon, May 6, 2019, 4:21 PM chefky <notifications@github.com> wrote:
   > >
   > > > Trying the latest snapshot with elasticsearch 7.0 -- getting an issue
   > > when
   > > > I update the zipkin-span_template. I need the tags field to be
   > searchable
   > > > since I am using tags.http.status_code to determine success rate of an
   > > API.
   > > > I just got the default value that is created by zipkin via 'GET
   > > > /_template/zipkin-span_template' in kibana, and edited the tags field
   > to:
   > > >
   > > > [image: Screen Shot 2019-05-06 at 4.03.24 PM.png]
   > > > Got this to work prior to latest snapshot + elasticsearch 7.0, but now
   > I
   > > > get an error:
   > > >
   > > > 2019-05-06 15:47:55.847 DEBUG 21101 --- [und.io:9243/...]
   > > > z.s.i.ZipkinHttpCollector : Cannot store spans
   > > > [327a37f9ae4eaa6d/52a9ba8e5a3f60f9, 327a37f9ae4eaa6d/87f3b8e489f2895b]
   > > due
   > > > to
   > > >
   > > >
   > >
   > IllegalStateException({"took":801,"errors":true,"items":[{"index":{"_index":"zipkin-span-2019-05-06","_type":"span","_id":"WewdjGoBqE8vRr9QDFH6","status":400,"error":{"type":"illegal_argument_exception","reason":"Can't
   > > > merge because of conflicts: [Cannot update excludes setting for
   > > >
   > > >
   > >
   > [_source]]"}}},{"index":{"_index":"zipkin-span-2019-05-06","_type":"span","_id":"WuwdjGoBqE8vRr9QDFH6","status":400,"error":{"type":"illegal_argument_exception","reason":"Can't
   > > > merge because of conflicts: [Cannot update excludes setting for
   > > > [_source]]"}}}]})
   > > >
   > > >
   > > > java.lang.IllegalStateException:
   > > >
   > > >
   > >
   > {"took":801,"errors":true,"items":[{"index":{"_index":"zipkin-span-2019-05-06","_type":"span","_id":"WewdjGoBqE8vRr9QDFH6","status":400,"error":{"type":"illegal_argument_exception","reason":"Can't
   > > > merge because of conflicts: [Cannot update excludes setting for
   > > >
   > > >
   > >
   > [_source]]"}}},{"index":{"_index":"zipkin-span-2019-05-06","_type":"span","_id":"WuwdjGoBqE8vRr9QDFH6","status":400,"error":{"type":"illegal_argument_exception","reason":"Can't
   > > > merge because of conflicts: [Cannot update excludes setting for
   > > > [_source]]"}}}]}
   > > >
   > > > at
   > > >
   > > >
   > >
   > zipkin2.elasticsearch.internal.HttpBulkIndexer$CheckForErrors.convert(HttpBulkIndexer.java:60)
   > > > ~[zipkin-storage-elasticsearch-2.13.1-SNAPSHOT.jar!/:2.13.1-SNAPSHOT]
   > > >
   > > > at
   > > >
   > > >
   > >
   > zipkin2.elasticsearch.internal.HttpBulkIndexer$CheckForErrors.convert(HttpBulkIndexer.java:53)
   > > > ~[zipkin-storage-elasticsearch-2.13.1-SNAPSHOT.jar!/:2.13.1-SNAPSHOT]
   > > >
   > > > at
   > > >
   > > >
   > >
   > zipkin2.elasticsearch.internal.client.HttpCall.parseResponse(HttpCall.java:151)
   > > > ~[zipkin-storage-elasticsearch-2.13.1-SNAPSHOT.jar!/:2.13.1-SNAPSHOT]
   > > >
   > > > at
   > > >
   > > >
   > >
   > zipkin2.elasticsearch.internal.client.HttpCall$V2CallbackAdapter.onResponse(HttpCall.java:128)
   > > > [zipkin-storage-elasticsearch-2.13.1-SNAPSHOT.jar!/:2.13.1-SNAPSHOT]
   > > >
   > > > at okhttp3.RealCall$AsyncCall.execute(RealCall.java:174)
   > > > [okhttp-3.14.0.jar!/:?]
   > > >
   > > > at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
   > > > [okhttp-3.14.0.jar!/:?]
   > > >
   > > > at
   > > >
   > > >
   > >
   > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
   > > > [?:1.8.0_191]
   > > >
   > > > at
   > > >
   > > >
   > >
   > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
   > > > [?:1.8.0_191]
   > > > at java.lang.Thread.run(Thread.java:748) [?:1.8.0_191]
   > > >
   > > > Tried to remove setting for _source but then I get this:
   > > >
   > > > "Rejecting mapping update to [zipkin-span-2019-05-06] as the final
   > > mapping
   > > > would have more than 1 type: [_doc, span]"
   > > >
   > > > Any ideas would be appreciated.
   > > >
   > > > Thanks,
   > > > Karen
   > > >
   > > >
   > > >
   > > >
   > > > On Fri, May 3, 2019 at 7:08 PM Adrian Cole <notifications@github.com>
   > > > wrote:
   > > >
   > > > > Merged #2398 <https://github.com/apache/incubator-zipkin/pull/2398>
   > > into
   > > > > master.
   > > > >
   > > > > —
   > > > > You are receiving this because you are subscribed to this thread.
   > > > > Reply to this email directly, view it on GitHub
   > > > > <
   > https://github.com/apache/incubator-zipkin/pull/2398#event-2317083480
   > > >,
   > > > > or mute the thread
   > > > > <
   > > >
   > >
   > https://github.com/notifications/unsubscribe-auth/AABS7KSYPFZA3IX5HJNRKPLPTQMMLANCNFSM4GYAFONQ
   > > > >
   > > > > .
   > > > >
   > > >
   > > > —
   > > > You are receiving this because you modified the open/close state.
   > > > Reply to this email directly, view it on GitHub
   > > > <
   > >
   > https://github.com/apache/incubator-zipkin/pull/2398#issuecomment-489543760
   > > >,
   > > > or mute the thread
   > > > <
   > >
   > https://github.com/notifications/unsubscribe-auth/AAAPVV7RYHPWL64LGQN6BNDPT7S7NANCNFSM4GYAFONQ
   > > >
   > > > .
   > > >
   > >
   > > —
   > > You are receiving this because you commented.
   > > Reply to this email directly, view it on GitHub
   > > <
   > https://github.com/apache/incubator-zipkin/pull/2398#issuecomment-489547378
   > >,
   > > or mute the thread
   > > <
   > https://github.com/notifications/unsubscribe-auth/AABS7KRX3FTRBGJRNLEAQFDPT7UWBANCNFSM4GYAFONQ
   > >
   > > .
   > >
   >
   > —
   > You are receiving this because you modified the open/close state.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-zipkin/pull/2398#issuecomment-489554650>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAAPVV4O7XKXOFZM5URKBPLPT7YDFANCNFSM4GYAFONQ>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message