zipkin-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-zipkin] adriancole commented on a change in pull request #2502: Adding storage-throttle module to address "over capacity" issues
Date Tue, 30 Apr 2019 23:56:21 GMT
adriancole commented on a change in pull request #2502: Adding storage-throttle module to address
"over capacity" issues
URL: https://github.com/apache/incubator-zipkin/pull/2502#discussion_r279978286
 
 

 ##########
 File path: zipkin-collector/core/src/main/java/zipkin2/collector/Collector.java
 ##########
 @@ -227,7 +228,13 @@ RuntimeException doError(String message, Throwable e) {
         message = format("%s due to %s(%s)", message, e.getClass().getSimpleName(), error);
         warn(message, e);
       }
-      return new RuntimeException(message, e);
 
 Review comment:
   answering, but yeah this was bonus points it can happen in another PR. In fact I'll go
ahead and do that now. Here's some notes.
   
   1. errors are always allowed through, it is Throwable/Exception that can't get through..
the logic above was slightly modified from other code we use.
   2. I think I wrote this code originally, there was no comment there.. it was not intended
to wrap unnecessarily.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message